Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secrets to unit test job #5083

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Add secrets to unit test job #5083

merged 1 commit into from
Sep 19, 2019

Conversation

mikenairn
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2019
@pmccarthy
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikenairn, pmccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c613270 into openshift:master Sep 19, 2019
@openshift-ci-robot
Copy link
Contributor

@mikenairn: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key integr8ly-integreatly-operator-master.yaml using file ci-operator/config/integr8ly/integreatly-operator/integr8ly-integreatly-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key integr8ly-integreatly-operator-master.yaml using file ci-operator/config/integr8ly/integreatly-operator/integr8ly-integreatly-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key integr8ly-integreatly-operator-master-presubmits.yaml using file ci-operator/jobs/integr8ly/integreatly-operator/integr8ly-integreatly-operator-master-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikenairn mikenairn deleted the add_secrets_to_unit_job branch September 19, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@pmccarthy pmccarthy Awaiting requested review from pmccarthy

Assignees

@pmccarthy pmccarthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikenairn @pmccarthy @openshift-ci-robot @openshift-merge-robot